[Data] Remove BulkExecutor code path
#40200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zandew
force-pushed
the
1006-deprecate-stage
branch
2 times, most recently
from
74fff54
to
5d2ebbb
Compare
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
Zandew
force-pushed
the
1006-deprecate-stage
branch
from
5d2ebbb
to
a067674
Compare
added 2 commits
October 13, 2023 12:10
Signed-off-by: Andrew Xue <andrewxue@anyscale.com>
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani,
raulchen and
stephanie-wang
as code owners
c21
approved these changes
Oct 16, 2023
bveeramani
reviewed
Oct 16, 2023
| from ray.data._internal.execution.legacy_compat import ( | ||
| execute_to_legacy_block_list, | ||
| ) | ||
| from ray.data._internal.execution.streaming_executor import ( | ||
| StreamingExecutor, | ||
| ) | ||
|
|
||
| if context.use_streaming_executor: |
There was a problem hiding this comment.
@scottjlee anything preventing us from removing use_streaming_executor from DataContext?
There was a problem hiding this comment.
i'm not sure, but i think we have several related fields like enable_optimizer as well, that we discussed and decided we want to remove together in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.