Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] add rows outputted to data metrics #40280

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 11, 2023

Why are these changes needed?

Exports rows outputted as a data metric to the ray dashboard.
Screenshot 2023-10-19 at 9 25 18 AM
Adds it to the ray data overview, replacing bytes outputted in the table.
Also adds CPU/GPU usage to the ray data overview
Screenshot 2023-11-16 at 10 18 32 AM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Zandew Zandew changed the title [data] assert metadata num_rows is non-None [data] add rows outputted to data metrics Oct 19, 2023
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@scottsun94
Copy link
Contributor

Thanks. Two comments?

  1. What does cpu usage mean here? Physical cpu usage or?
  2. The progress bar is getting too short. Can we set a min width for it and enable horizontal scaling if there are too many rows?

@Zandew
Copy link
Contributor Author

Zandew commented Nov 15, 2023

  1. What does cpu usage mean here? Physical cpu usage or?

It is logical, the image is outdated, but there's a tooltip that clarifies this. I thought the header was getting too long so I put it in a tooltip

  1. The progress bar is getting too short. Can we set a min width for it and enable horizontal scaling if there are too many rows?

👍

@scottsun94
Copy link
Contributor

Can we say "Logical CPU usage (current / max)" or "Logical GPU usage (current / max)" then? We can wrap the text to avoid a really wide column, like this:

Screenshot 2023-11-14 at 7 55 38 PM

Btw, can we use lower case for the "current" and "max"?

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@c21 c21 merged commit 384b694 into ray-project:master Nov 16, 2023
16 of 19 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Exports rows outputted as a data metric to the ray dashboard.
Adds it to the ray data overview, replacing bytes outputted in the table.
Also adds CPU/GPU usage to the ray data overview.

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants