Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][streaming][python] Fix asyncio.wait coroutines args deprecated warnings #40292

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Oct 12, 2023

Why are these changes needed?

Passing coroutines directly to asyncio.wait is deprecating (warnings in >3.8, and deprecated >3.10)

We should not be doing it.

Related issue number

Closes #40250

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Running the repro has no more warnings in python 3.9.

import time
import ray
import asyncio

@ray.remote(num_returns="streaming")
def task():
    for i in range(5):
        time.sleep(1)
        yield i


async def main():
    async for ref in task.remote():
        print(await ref)

asyncio.run(main())

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 12, 2023
@rickyyx rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 17, 2023
@rkooo567 rkooo567 merged commit 5f832b3 into ray-project:master Oct 18, 2023
63 of 66 checks passed
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
… warnings ray-project#40292

Passing coroutines directly to asyncio.wait is deprecating (warnings in >3.8, and deprecated >3.10)

We should not be doing it.
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
… warnings ray-project#40292

Passing coroutines directly to asyncio.wait is deprecating (warnings in >3.8, and deprecated >3.10)

We should not be doing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Ray streaming generator uses incorrect APIs in asyncio when used with Python > 3.9
2 participants