[Data] Deprecate extraneous Dataset parameters and methods
#40385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <sjl@anyscale.com>
… methods Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani,
raulchen and
stephanie-wang
as code owners
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
…ject#40385) - Removes `lazy` parameter from `Dataset.__init__()` and its associated methods - Removes `epoch` parameter from `Dataset.__init__()` and its associated methods - Removes methods labeled with the `@Deprecated` decorator: `Dataset.fully_executed()`, `Dataset.is_fully_executed()`, `Dataset.default_batch_format()`, `Dataset.dataset_format()`, `range_table()` - Clean up tests using the above parameters, methods, attributes, etc. Signed-off-by: Scott Lee <sjl@anyscale.com>
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
…ject#40385) - Removes `lazy` parameter from `Dataset.__init__()` and its associated methods - Removes `epoch` parameter from `Dataset.__init__()` and its associated methods - Removes methods labeled with the `@Deprecated` decorator: `Dataset.fully_executed()`, `Dataset.is_fully_executed()`, `Dataset.default_batch_format()`, `Dataset.dataset_format()`, `range_table()` - Clean up tests using the above parameters, methods, attributes, etc. Signed-off-by: Scott Lee <sjl@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
lazyparameter fromDataset.__init__()and its associated methodsepochparameter fromDataset.__init__()and its associated methods@Deprecateddecorator:Dataset.fully_executed(),Dataset.is_fully_executed(),Dataset.default_batch_format(),Dataset.dataset_format(),range_table()Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.