Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] remove test_client.py #40415

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Oct 17, 2023

Why are these changes needed?

This test suite tests a bunch of Tune examples with Ray Client.

This PR removes these tests because:

  1. The Ray Tune / Ray Client integration is not being maintained. The functionality is not documented nor is it expected to be "stable".
  2. These tests are extremely flaky, which mostly seems to be due to timeouts.
  3. The non-Client version of these examples are being tested in other test suites.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng merged commit 929b445 into ray-project:master Oct 18, 2023
75 of 80 checks passed
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants