[Data] Remove deprecated do_write
#40422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen and
stephanie-wang
as code owners
8 tasks
|
lgtm, i also see |
…ve-do-write3 Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Ah, good catch. Should've be removed in #40127. Rather than opening up a new PR and waiting for CI to run, I'm including it in this PR. |
scottjlee
approved these changes
Oct 18, 2023
Comment on lines
-3486
to
-3494
| progress = ProgressBar("Write Progress", len(write_results)) | ||
| try: | ||
| progress.block_until_complete(write_results) | ||
| datasource.on_write_complete(ray.get(write_results)) | ||
| except Exception as e: | ||
| datasource.on_write_failed(write_results, e) | ||
| raise | ||
| finally: | ||
| progress.close() |
There was a problem hiding this comment.
did we keep this progress bar logic elsewhere? or now it is just managed by Write operator?
There was a problem hiding this comment.
Yeah, it's just handled by the operator (e.g, ReadRange->Write)
16 tasks
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
do_write has been deprecated since Ray 2.4. This PR removes it. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
do_write has been deprecated since Ray 2.4. This PR removes it. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Why are these changes needed?
do_writehas been deprecated since Ray 2.4. This PR removes it.Related issue number
Towards #40296
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.