Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Improve error message when reading HTTP files #40462

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

If you try to read HTTP files with Ray Data, you get this error message if fsspect[http] isn't installed:

Please install fsspec to read files from HTTP.

This PR updates the error message to clarify that you need the http extra:

To read files from HTTP, run pip install fsspec[http].

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 819733f into ray-project:master Oct 18, 2023
28 of 34 checks passed
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
If you try to read HTTP files with Ray Data, you get this error message if fsspect[http] isn't installed:

> Please install fsspec to read files from HTTP.

This PR updates the error message to clarify that you need the http extra:

> To read files from HTTP, run pip install fsspec[http].

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
If you try to read HTTP files with Ray Data, you get this error message if fsspect[http] isn't installed:

> Please install fsspec to read files from HTTP.

This PR updates the error message to clarify that you need the http extra:

> To read files from HTTP, run pip install fsspec[http].

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants