-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train] Improve loggings for Train worker scheduling information #40536
[Train] Improve loggings for Train worker scheduling information #40536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottsun94 can you leave your thoughts? Originally we wanted to keep it succinct but found that it is not sufficient for users to debug certain issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since it only shows up once (unless there are location changes), it's fine to be a bit more verbose.
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
LGTM. Thanks! |
Why are these changes needed?
Currently, the placement and ranking information of distributed process groups in the log is unclear. Users must manually print out the world ranking, local ranking, and node IP. This PR improves log messages with more placement information to improve observability and debuggability.
Previous:
Now:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.