should not fetch runtime-info of vm from cached_nodes #40655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Hui <huchen@vmware.com>
huchen2021
requested review from
ericl,
architkulkarni and
a team
as code owners
architkulkarni
approved these changes
Oct 25, 2023
|
Core, serve, rllib tests unrelated |
architkulkarni
added
the
tests-ok
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
Oct 25, 2023
…hed_nodes (ray-project#40655) Power-on-off status is runtime info of VM, should not fetch it from cached-nodes, which is probably dirty data. It should query by pyvmomi_sdk every time. Signed-off-by: Chen Hui <huchen@vmware.com>
8 tasks
vitsai
pushed a commit
that referenced
this pull request
Oct 26, 2023
…sue and support GPU nodes (#40667) * [Cluster launcher] [vSphere] Fix the bug that multiple worker types doesn't work (#40487) Currently our code assumes that there is only one worker node type. In this change I fix the bug to let it support multiple worker node types. Signed-off-by: Chen Jing <jingch@vmware.com> Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> * [cluster launcher] [vSphere Provider] Fix vc conn timout issue (#40516) Fixed the issue using SessionOrientedStub. A session-oriented stub adapter that will relogin to the destination if a session-oriented exception is thrown. --------- Signed-off-by: Chen Jing <jingch@vmware.com> * [cluster launcher] [vSphere Provider] Support GPU Ray nodes on vSphere (#40616) This is for supporting passthrough the GPU on vSphere ESXi host into the Ray nodes. --------- Signed-off-by: Chen Jing <jingch@vmware.com> * [cluster launcher] [vSphere] Do not fetch runtime-info of vm from cached_nodes (#40655) Power-on-off status is runtime info of VM, should not fetch it from cached-nodes, which is probably dirty data. It should query by pyvmomi_sdk every time. Signed-off-by: Chen Hui <huchen@vmware.com> --------- Signed-off-by: Chen Jing <jingch@vmware.com> Signed-off-by: Chen Hui <huchen@vmware.com> Co-authored-by: Chen Jing <jingch@vmware.com> Co-authored-by: huchen2021 <85480625+huchen2021@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Power-on-off status is runtime info of VM, should not fetch it from cached-nodes, which is probably dirty data.
It should query by pyvmomi_sdk every time.
Test
We have internal automation pipelines passed. Also team tested the GPU functionalities manually.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.