Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Remove RLlib contrib warnings from AlgorithmConfig (should only remain in Algorithm class itself). #40744

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[RLlib] Remove RLlib contrib warnings from AlgorithmConfig (should only remain in Algorithm class itself). #40744

merged 1 commit into from
Oct 27, 2023

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Oct 27, 2023 •
edited by sven1977

Remove RLlib contrib warnings from AlgorithmConfig (should only remain in Algorithm class itself).

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980
Removed 'rllib_contrib' warning.
3feb11b 
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
sven1977 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @simonsays1980 !

@sven1977 sven1977 changed the title Removed 'rllib_contrib' warning. [RLlib] Remove RLlib contrib warnings from AlgorithmConfig (should only remain in Algorithm class itself). Oct 27, 2023
@sven1977 sven1977 merged commit 68d1feb into ray-project:master Oct 27, 2023
21 of 25 checks passed
sven1977 pushed a commit that referenced this pull request Oct 27, 2023
@simonsays1980 @sven1977
[RLlib] Remove RLlib contrib warnings from AlgorithmConfig (should on…
16d8934 
…ly remain in Algorithm class itself). (#40744)
@sven1977 sven1977 mentioned this pull request Oct 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonsays1980 @sven1977