[data] add support for multiple group keys in map_groups #40778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingkitlee0
force-pushed
the
map-groups-multi-keys
branch
4 times, most recently
from
77ea576
to
71bbb60
Compare
|
FYI @LeonLuttenberger |
wingkitlee0
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
Zandew
as code owners
wingkitlee0
force-pushed
the
map-groups-multi-keys
branch
2 times, most recently
from
4ba55fb
to
1dd29f4
Compare
bveeramani
reviewed
Nov 7, 2023
python/ray/data/grouped_data.py
Outdated
Comment on lines
332
to
333
| x = np.empty(1, dtype=object) | ||
| x[0] = arr[start] |
There was a problem hiding this comment.
What's going on here? Also, could we rename x with a more descriptive name?
There was a problem hiding this comment.
After constructing an array of tuples, the target value x of the np.searchsorted needs to be a single-element tuple ndarray. Otherwise, searchsorted complains about the missing < operator. Alternatively, we can add a small custom tuple class with __lt__ method instead of using built-in tuples for this PR.
|
@bveeramani Thanks for taking a look. I left some comments and will update the PR in a few days. |
wingkitlee0
force-pushed
the
map-groups-multi-keys
branch
from
c70ef4f
to
2a1b654
Compare
|
Thanks! Will take a look sometime next week |
bveeramani
approved these changes
Nov 14, 2023
Signed-off-by: Kit Lee <wklee4993@gmail.com>
wingkitlee0
force-pushed
the
map-groups-multi-keys
branch
from
b2376ee
to
a05b1a4
Compare
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…#40778) Need to fix get_key_boundaries in order to use multiple keys in map_groups Signed-off-by: Kit Lee <wklee4993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Need to fix get_key_boundaries in order to use multiple keys in
map_groupsRelated issue number
Closes #40774
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.