Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib, rllib_contrib] Issue errors (instead of warnings) when using rllib_contrib algos. #40789

Merged
merged 32 commits into from
Nov 2, 2023
Merged

[RLlib, rllib_contrib] Issue errors (instead of warnings) when using rllib_contrib algos. #40789

merged 32 commits into from
Nov 2, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 30, 2023 •
edited

Issue errors (instead of warnings) when using rllib_contrib algos.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
79801b3 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
587b547 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
14cb992 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
fa010b0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
1e6d3c2 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' into rllib_contrib_error_instead_of_warnings
4c871ba 
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
@sven1977
wip
0972d3a 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
3c3d5a8 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge remote-tracking branch 'origin/rllib_contrib_error_instead_of_w…
90f796a 
…arnings' into rllib_contrib_error_instead_of_warnings
@sven1977
wip
f03a566 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
854e9cc 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
e565b09 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
a6bdb9e 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
3ffbe6e 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
3acf3e6 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
7766093 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
8b64a66 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
adc10f0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
723cc65 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
790c450 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into rlli…
42b866f 
…b_contrib_error_instead_of_warnings
@sven1977
wip
4dbd2b5 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
4a8e866 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 requested a review from a team as a code owner November 1, 2023 12:40
@sven1977
wip
1a62052 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into rlli…
0789744 
…b_contrib_error_instead_of_warnings
@sven1977
wip
4169859 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
8e25005 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
959f55f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
6bd5b95 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
c2838b0 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
0a5a8bb 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
7fedbc2 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 918d738 into ray-project:master Nov 2, 2023
47 of 55 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
@sven1977 @ujjawal-khare
[RLlib, rllib_contrib] Issue errors (instead of warnings) when using …
99cc9fa 
…`rllib_contrib` algos. (ray-project#40789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sven1977 @kouroshHakha