Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] log progress bar to data logs #40814

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 30, 2023

Why are these changes needed?

Log each operator's progress bar to ray-data.log after each _scheduling_loop_step if DEBUG_TRACE_SCHEDULING is not set.

Example: ray.data.range(100).map_batches(lambda x: x).materialize():

2023-10-31 15:41:26,646 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:26,646 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:26,646 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 10 queued, 0.02 MiB objects, Blocks Outputted: 0/20
2023-10-31 15:41:26,646 INFO streaming_executor.py:430 --
2023-10-31 15:41:26,646 INFO streaming_executor.py:312 -- Operator InputDataBuffer[Input] completed. Operator Metrics:
{'num_inputs_received': 20, 'bytes_inputs_received': 45900, 'num_outputs_taken': 20, 'bytes_outputs_taken': 45900, 'cpu_usage': 0, 'gpu_usage': 0}
2023-10-31 15:41:26,757 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:26,757 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:26,757 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 9 queued, 0.02 MiB objects, Blocks Outputted: 1/20
2023-10-31 15:41:26,757 INFO streaming_executor.py:430 --
2023-10-31 15:41:26,866 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:26,866 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:26,866 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 8 queued, 0.02 MiB objects, Blocks Outputted: 2/20
2023-10-31 15:41:26,866 INFO streaming_executor.py:430 --
2023-10-31 15:41:26,972 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:26,972 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:26,972 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 7 queued, 0.02 MiB objects, Blocks Outputted: 3/20
2023-10-31 15:41:26,972 INFO streaming_executor.py:430 --
2023-10-31 15:41:27,079 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:27,079 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:27,079 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 6 queued, 0.02 MiB objects, Blocks Outputted: 4/20
2023-10-31 15:41:27,079 INFO streaming_executor.py:430 --
2023-10-31 15:41:27,187 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:27,188 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:27,188 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 10 active, 5 queued, 0.02 MiB objects, Blocks Outputted: 5/20
2023-10-31 15:41:27,188 INFO streaming_executor.py:430 --
2023-10-31 15:41:27,290 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:27,290 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:27,290 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 5 active, 0 queued, 0.01 MiB objects, Blocks Outputted: 15/20
2023-10-31 15:41:27,290 INFO streaming_executor.py:430 --
2023-10-31 15:41:27,293 INFO streaming_executor.py:424 -- Execution Progress:
2023-10-31 15:41:27,293 INFO streaming_executor.py:426 -- 0: - Input: 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:27,293 INFO streaming_executor.py:426 -- 1: - ReadRange->MapBatches(<lambda>): 0 active, 0 queued, 0.0 MiB objects, Blocks Outputted: 20/20
2023-10-31 15:41:27,293 INFO streaming_executor.py:430 --

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @raulchen as well.

python/ray/data/_internal/execution/streaming_executor.py Outdated Show resolved Hide resolved
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@raulchen raulchen merged commit 9febd97 into ray-project:master Nov 1, 2023
27 of 28 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
---------

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants