Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Avoid slicing too-small blocks #40840

Merged
merged 7 commits into from
Nov 3, 2023
Merged

[data] Avoid slicing too-small blocks #40840

merged 7 commits into from
Nov 3, 2023

Conversation

stephanie-wang
Copy link
Contributor

@stephanie-wang stephanie-wang commented Oct 31, 2023 •
edited

Why are these changes needed?

Block slicing may create blocks that are very small. This PR ensures that we do not produce blocks < 50% the target block size during block slicing.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@stephanie-wang
fix?
65298c8 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang stephanie-wang changed the title [donotmerge][data] test [donotmerge][data] test iter_tensors benchmark Oct 31, 2023
@stephanie-wang
Merge remote-tracking branch 'upstream/master' into block-slicing
15f8a05
@stephanie-wang
update test
e5e3b1d 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang
test?
39fe0d9 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang
test
4739618 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang
x
97d5993 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang stephanie-wang changed the title [donotmerge][data] test iter_tensors benchmark [data] Avoid slicing too-small blocks Nov 3, 2023
@stephanie-wang
fix test
50e882d 
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang stephanie-wang merged commit f22137d into ray-project:master Nov 3, 2023
25 of 28 checks passed
@stephanie-wang stephanie-wang deleted the block-slicing branch November 3, 2023 21:43
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
@stephanie-wang @ujjawal-khare
[data] Avoid slicing too-small blocks (ray-project#40840)
919fc13 
Block slicing may create blocks that are very small. This PR ensures that we do not produce blocks < 50% the target block size during block slicing.

---------

Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@Zandew Zandew Awaiting requested review from Zandew

Assignees

@raulchen raulchen

@c21 c21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephanie-wang @raulchen @c21