Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] add AllToAllAPI to dataset methods #40842

Merged
merged 10 commits into from
Nov 2, 2023
Merged

[data] add AllToAllAPI to dataset methods #40842

merged 10 commits into from
Nov 2, 2023

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Oct 31, 2023 •
edited

Why are these changes needed?

Adds an AllToAllAPI decorator for Dataset methods that create all-to-all operators.
Screenshot 2023-10-31 at 5 50 46 PM

The list:

  • repartition
  • random_shuffle
  • randomize_block_order
  • groupby
  • unique
  • aggregate
  • sum
  • min
  • max
  • mean
  • std
  • sort

Please let me know if I missed any

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Zandew
all to all api
ca2e5da 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
fix
276ecbd 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
fix
7cfa50c 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
fix
3bd73d4 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
fix
835ebf0 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
copy
32b3256 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew Zandew changed the title all to all api [data] add AllToAllAPI to dataset methods Nov 1, 2023
@Zandew
period
31cec87 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew Zandew marked this pull request as ready for review November 1, 2023 00:53
c21
c21 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Zandew and others added 3 commits November 1, 2023 11:31
@Zandew
lint
0af12a8 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@Zandew
fix
8bdfe21 
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
@c21
Merge branch 'master' into all-to-all-api
3af2081
@c21 c21 merged commit 45ac625 into ray-project:master Nov 2, 2023
25 of 28 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
@Zandew @c21 @ujjawal-khare
[data] add AllToAllAPI to dataset methods (ray-project#40842)
a10e42a 
Adds an `AllToAllAPI` decorator for `Dataset` methods that create all-to-all operators.

The list:

- repartition
- random_shuffle
- randomize_block_order
- groupby
- unique
- aggregate
- sum
- min
- max
- mean
- std
- sort

Please let me know if I missed any

Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Co-authored-by: Cheng Su <scnju13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

Assignees

@c21 c21

@scottjlee scottjlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zandew @c21 @scottjlee