Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] SampleBatch slicing crashes when using tf + SEQ_LENS + zero-padding. #40905

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 2, 2023

SampleBatch slicing crashes when using tf + SEQ_LENS + zero-padding.

In the following scenario, an error is thrown:

SampleBatch B w/ seq_lens=[16, 16, 16, 16, 16, 16, 2, 2, 14, 14] and max_seq_len=16 (zero-padded)

Then do as slice:

B[128:]

# and get error:
...
  File "/home/thwu/miniconda3/envs/py310/lib/python3.10/site-packages/ray/rllib/policy/sample_batch.py", line 911, in __getitem__
    return self._slice(key)
  File "/home/thwu/miniconda3/envs/py310/lib/python3.10/site-packages/ray/rllib/policy/sample_batch.py", line 1122, in _slice
    stop_seq_len, stop_unpadded = self._slice_map[stop]
IndexError: list index out of range

Other values in B:

len self: 160 (zero padded)
len slice map: 129
slice_.start: 128
slice_.stop: None
slice_map: [(0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (1, 16), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (2, 32), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (3, 48), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (4, 64), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (5, 80), (6, 96), (6, 96), (7, 98), (7, 98), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (8, 100), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (9, 114), (10, 128)], 
stop: 160

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit f8f6bde into ray-project:master Nov 4, 2023
22 of 26 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants