-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data] add operator-level dropdown to ray data overview #40981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zandew
force-pushed
the
operator-level-table
branch
from
November 6, 2023 19:47
133685d
to
f35f20b
Compare
LGTM. Thanks! |
Zandew
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen and
stephanie-wang
as code owners
November 7, 2023 23:30
scottjlee
approved these changes
Nov 8, 2023
alanwguo
reviewed
Nov 8, 2023
alanwguo
reviewed
Nov 9, 2023
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Signed-off-by: Andrew Xue <andewzxue@gmail.com>
Zandew
force-pushed
the
operator-level-table
branch
from
November 13, 2023 05:04
1f966ea
to
372e2b5
Compare
stephanie-wang
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/data changes look good.
alanwguo
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! lgtm
Co-authored-by: Alan Guo <aguo@aguo.software> Signed-off-by: Andrew Xue <andewzxue@gmail.com>
raulchen
approved these changes
Nov 13, 2023
c21
approved these changes
Nov 14, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…40981) Adds a dropdown for operator level metrics for each dataset row in the ray data table. In addition to storing dataset state, `_StatsActors` now also stores operator level state. Signed-off-by: Andrew Xue <andewzxue@gmail.com> Co-authored-by: Alan Guo <aguo@aguo.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a dropdown for operator level metrics for each dataset row in the ray data table.
In addition to storing dataset state,
_StatsActors
now also stores operator level state.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.