Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] Update TensorFlow ReportCheckpointCallback to delete temporary directory #41033

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

ReportCheckpointCallback creates a TensorflowCheckpoint, which will create a temporary directory to hold the checkpoint state. After ReportCheckpointCallback calls train.report, it should clean up this temporary directory, as the checkpoint is now persisted to the final storage location.

Related issue number

Closes #40956

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…y directory

Signed-off-by: Matthew Deng <matt@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 one suggestion

python/ray/air/integrations/keras.py Outdated Show resolved Hide resolved
Signed-off-by: Matthew Deng <matt@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@matthewdeng matthewdeng merged commit 400831e into ray-project:master Nov 8, 2023
20 of 26 checks passed
@matthewdeng matthewdeng deleted the tf-tempdir branch November 8, 2023 21:14
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
…y directory (ray-project#41033)

Signed-off-by: Matthew Deng <matt@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[<Ray component: Tune>] TensorflowCheckpoint Temp Folder is hard coded to system variable
3 participants