Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Restoring from a checkpoint from an older wheel (where AlgorithmConfig.rl_module_spec was NOT a @property yet) breaks when trying to load from this checkpoint in current version. #41157

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 15, 2023

Restoring from a checkpoint from an older wheel (where AlgorithmConfig.rl_module_spec was NOT a @Property yet) breaks when trying to load from this checkpoint in current version.

IMPORTANT: Noted that we need to be much more careful in the future about changing these (very central) config properties and make any renamings redundant/backward compatible.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 227fe5d into ray-project:master Nov 15, 2023
16 of 18 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
…thmConfig.rl_module_spec was NOT a @Property yet) breaks when trying to load from this checkpoint. (ray-project#41157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants