Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Expose max_retry_cnt parameter for BigQuery Write #41163

Merged
merged 11 commits into from
Nov 19, 2023

Conversation

matthew29tang
Copy link
Contributor

Why are these changes needed?

Exposing max_retry_cnt to the user will give them more flexibility to increase the number of retries for very large writes that may encounter more rate limit exceptions.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Tang <tangmatthew@google.com>
Signed-off-by: Matthew Tang <tangmatthew@google.com>
@matthew29tang matthew29tang changed the title Expose max_retry_cnt parameter for BigQuery Write [Data] Expose max_retry_cnt parameter for BigQuery Write Nov 15, 2023
@bveeramani bveeramani self-assigned this Nov 18, 2023
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
Signed-off-by: Matthew Tang <tangmatthew@google.com>
Signed-off-by: Matthew Tang <tangmatthew@google.com>
@bveeramani bveeramani merged commit 84c0ba0 into ray-project:master Nov 19, 2023
13 of 16 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
…#41163)

Exposing max_retry_cnt to the user will give them more flexibility to increase the number of retries for very large writes that may encounter more rate limit exceptions.

---------

Signed-off-by: Matthew Tang <tangmatthew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants