[data] allow ConcurrencyCapBackpressurePolicy._cap_multiplier to be set to 1.0 #41222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
Zandew
as code owners
stephanie-wang
approved these changes
Nov 17, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…et to 1.0 (ray-project#41222) Allow ConcurrencyCapBackpressurePolicy._cap_multiplier to be set to 1.0. This means that the concurrency will stay the same. No ramping up. This is because for some workloads, we need an upper bound of concurrency cap to make it stable. Before introducing new configs for control concurrency. Add this as a temporary workaround. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Allow ConcurrencyCapBackpressurePolicy._cap_multiplier to be set to 1.0. This means that the concurrency will stay the same. No ramping up. This is because for some workloads, we need an upper bound of concurrency cap to make it stable. Before introducing new configs for control concurrency. Add this as a temporary workaround.
Related issue number
#41193
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.