Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix the missing ray module import in PyTorch Guide #41300

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[Doc] Fix the missing ray module import in PyTorch Guide #41300

merged 1 commit into from
Nov 21, 2023

Conversation

jiwq
Copy link
Contributor

@jiwq jiwq commented Nov 21, 2023

Why are these changes needed?

Missing the ray module import in PyTorch Guide

Related issue number

Closes #41291

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jiwq
[Doc] Fix the missing ray module import in PyTorch Guide
11fcc0a 
Signed-off-by: Wanqiang Ji <me@jiwq.cn>
justinvyu
justinvyu approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@justinvyu justinvyu merged commit beb87b4 into ray-project:master Nov 21, 2023
9 of 10 checks passed
@jiwq jiwq deleted the pytorch-guide branch November 22, 2023 15:11
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
@jiwq @ujjawal-khare
[Doc] Fix the missing ray module import in PyTorch Guide (ray-project…
930bf7c 
…#41300)

Signed-off-by: Wanqiang Ji <me@jiwq.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvyu justinvyu justinvyu approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Train] Missing the ray module import in PyTorch Guide
2 participants
@jiwq @justinvyu