Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix Path Resolution on Windows #41388

Merged
merged 2 commits into from Nov 27, 2023

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Nov 27, 2023

Why are these changes needed?

#39018 makes an implicit assumption that the host OS is Posix and that path resolution follows Posix convention. I don't actually need any of the 'host-specific' aspects of pathlib and only want the Pure Posix path semantics.

Related issue number

Closes #41379

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: ijrsvt <ian.rodney@gmail.com>
Signed-off-by: ijrsvt <ian.rodney@gmail.com>
@mattip
Copy link
Contributor

mattip commented Nov 27, 2023

I can confirm that this solves the problem when applied locally on top of 2.8.0

@mattip
Copy link
Contributor

mattip commented Nov 27, 2023

Also closes #41081

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Nov 27, 2023

Thank you @mattip for checking that this fixes it for Windows! You saved me from having to dust off a Windows machine to test this out 🥳

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Nov 27, 2023

Merging because test failures are unrelated because they only apply to Docs.

@ijrsvt ijrsvt merged commit d98e7ff into ray-project:master Nov 27, 2023
14 of 15 checks passed
@ijrsvt ijrsvt deleted the fix-dashboard-on-windows branch November 27, 2023 17:44
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Use 'PurePosixPaths' when trying to canonicalize URL paths. This ensures that path resolution is independent of the underlying operating system and fixes the Ray Dashboard for Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Error 403 for ray dashboard on localhost in ray 2.8.0
3 participants