[core] Make number of connections and thread number of object manager client tunable. #41421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Nov 28, 2023
rkooo567
approved these changes
Nov 28, 2023
| @@ -886,3 +886,5 @@ RAY_CONFIG(bool, enable_autoscaler_v2, false) | |||
| // Python GCS client number of reconnection retry and timeout. | |||
| RAY_CONFIG(int64_t, nums_py_gcs_reconnect_retry, 5) | |||
| RAY_CONFIG(int64_t, py_gcs_connect_timeout_s, 30) | |||
|
|
|||
| RAY_CONFIG(int, object_manager_client_connection_num, 4) | |||
There was a problem hiding this comment.
can you comment what's the impact of tuning this value here? Like what does higher value imply vs lower value imply
rkooo567
added
the
@author-action-required
fishbone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The number of connections will impact the transfer performance. Make it tunable for now so that the user can just increase it on demands.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.