[core] Add an internal system concurrency group for executing compiled dag tasks #41605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanie-wang
approved these changes
Dec 5, 2023
rkooo567
approved these changes
Dec 6, 2023
| @@ -164,6 +164,21 @@ def f2(self): | |||
| assert "ok" == ray.get(async_actor.f2.remote()) | |||
|
|
|||
|
|
|||
| def test_system_concurrency_group(ray_start_regular_shared): | |||
There was a problem hiding this comment.
can you test if users provide the default concurrency group, it raises an excepetion?
# It should fail.
@ray.remote(concurrency_groups={"_ray_system": 2})
class Actor:
...Also it seems like concurrency group has a value (to limit concurrency). What's the default for the system concurrency group? Just 1?
There was a problem hiding this comment.
I think this is fine--- it's an internal feature and we don't provide any guarantees on how it works.
rkooo567
added
the
@author-action-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As part of https://github.com/ray-project/enhancements/pull/48/files, we need the ability to launch system-managed tasks to execute compiled DAG work. These need to run in a separate concurrency group so they do not block other actor tasks.
This is an internal/experimental API only.