[RLlib] Fixed errors in 'MultiAgentEPisode' tests. Due to the use of 'BufferW… #41631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithInfiniteLookback' and a different format for extra model outputs (instead of list of dicts now dict of 'BufferWithInfiniteLookback'). Added a '__add__'' method to 'BufferWithInfiniteLookback' and refined the '_getattr_by_index' method to use a 'key' for the specific key in the extra model outputs that should be returned. The getters need a major refinement when 'Connector API' is finished and it is decided if only SAE or also MAE needs a lookback. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
changed the title
sven1977
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
kouroshHakha
as code owners
sven1977
reviewed
Dec 6, 2023
sven1977
reviewed
Dec 6, 2023
sven1977
reviewed
Dec 6, 2023
sven1977
reviewed
Dec 6, 2023
sven1977
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
LGTM. Thanks @simonsays1980 ! Just some PPO EnvRunner tests are failing. Could you check these?
… 'BufferWithInfinitelookback' and need the getters to recevie numpy arrays. Tests run now. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…/ray into refine-multi-agent-episode Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ithInfiniteLookback' and a different format for extra model outputs (instead of list of dicts now dict of 'BufferWithInfiniteLookback'). Added a 'add'' method to 'BufferWithInfiniteLookback' and refined the '_getattr_by_index' method to use a 'key' for the specific key in the extra model outputs that should be returned. The getters need a major refinement when 'Connector API' is finished and it is decided if only SAE or also MAE needs a lookback.
Why are these changes needed?
Due to the switch from
listtoBufferWithInfiniteLookbacktheMultiAgentEpisodeneeded some refinements b/c some tests did not run anymore. Furthermore, there are some changes in the extra model outputs that threw exceptions.Related issue number
Relates to #40746
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.