Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Optimize OpState.outqueue_num_blocks #41748

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Dec 8, 2023

Why are these changes needed?

Cache num_blocks in the output queue and avoid iterating the whole queue every time.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen merged commit 5958771 into ray-project:master Dec 12, 2023
14 of 15 checks passed
@raulchen raulchen deleted the optimize-outqueue branch December 12, 2023 01:07
raulchen added a commit to raulchen/ray that referenced this pull request Dec 12, 2023
Signed-off-by: Hao Chen <chenh1024@gmail.com>
architkulkarni pushed a commit that referenced this pull request Dec 12, 2023
Cherry-pick #41748 to 2.9.0 release. This is a simple and safe perf fix and confirmed to be a bottleneck for training ingestion workloads.

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants