Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][Doc][Train] Improve torch, lightning quickstarts and migration guides + fix torch restoration example #41843

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

This PR improves some of our Ray Train user guides (torch, lightning, transformers) by fixing some of our code snippets in the quickstarts and checkpointing guide.

This is a cherry-pick of #41330.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…s + fix torch restoration example (ray-project#41330)

This PR improves some of our Ray Train user guides (torch, lightning, transformers) by fixing some of our code snippets in the quickstarts and checkpointing guide.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@architkulkarni
Copy link
Contributor

Doc build failed, restarting tests

@architkulkarni architkulkarni merged commit 63a6b98 into ray-project:releases/2.9.0 Dec 14, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants