[Core] Update doc for Ray core accelerator support #41849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelinalg
approved these changes
Dec 13, 2023
jjyao
commented
Dec 13, 2023
| @@ -87,14 +87,14 @@ def construct_metadata() -> WorkerMetadata: | |||
| node_id = ray.get_runtime_context().get_node_id() | |||
| node_ip = ray.util.get_node_ip_address() | |||
| hostname = socket.gethostname() | |||
| resource_ids = ray.get_runtime_context().get_resource_ids() | |||
| accelerator_ids = ray.get_runtime_context().get_accelerator_ids() | |||
There was a problem hiding this comment.
@matthewdeng I deprecated get_resource_ids() and introduced get_accelerator_ids() as we discussed. You may want to change train side as well.
anyscalesam
requested changes
Dec 13, 2023
rickyyx
approved these changes
Dec 13, 2023
anyscalesam
approved these changes
Dec 13, 2023
jjyao
added a commit
that referenced
this pull request
Dec 13, 2023
- Include docs for accelerators other than GPU - Replace RuntimeContext.get_resource_ids() with RuntimeContext.get_accelerator_ids() Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
architkulkarni
pushed a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.