Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train+tune] Make path joining OS-agnostic by using Path.as_posix over os.path.join #42037

Merged
merged 19 commits into from
Jan 31, 2024
Merged

[train+tune] Make path joining OS-agnostic by using Path.as_posix over os.path.join #42037

merged 19 commits into from
Jan 31, 2024

Commits on Dec 21, 2023

  1. use posix path for windows with s3 compatibility 

    Signed-off-by: n3011 <mrinal.haloi11@gmail.com>
    @n3011
    n3011 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d419277 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Ishant Mrinal <33053278+n30111@users.noreply.github.com>
Signed-off-by: n3011 <mrinal.haloi11@gmail.com>
    @n30111 @justinvyu @n3011
    2 people authored and n3011 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    75f2c38 View commit details
    Browse the repository at this point in the history

  3. update path syntax 

    Signed-off-by: n3011 <mrinal.haloi11@gmail.com>
    @n3011
    n3011 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d979f76 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into win_path_fix

    @n30111
    n30111 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    2829cb8 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'master' of https://github.com/ray-project/ray into win_… 

    …path_fix
    @justinvyu
    justinvyu committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    57ed08e View commit details
    Browse the repository at this point in the history

  2. easy replacements: 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    80e723c View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. update exclude pattern logic to always check for posix style 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6eaf362 View commit details
    Browse the repository at this point in the history

  2. finish easy train replacements 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    195ac65 View commit details
    Browse the repository at this point in the history

  3. update exp analysis paths 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    55b4c0c View commit details
    Browse the repository at this point in the history

  4. make callback can_restore more efficient 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cf216d4 View commit details
    Browse the repository at this point in the history

  5. tune_controller, trial, progress reporter 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ad0ca97 View commit details
    Browse the repository at this point in the history

  6. replace for csv logger 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    11f77a2 View commit details
    Browse the repository at this point in the history

  7. finish fixing loggers 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8640a58 View commit details
    Browse the repository at this point in the history

  8. basic variant 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8ef4ca3 View commit details
    Browse the repository at this point in the history

  9. fix trainable 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    17aa499 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of https://github.com/ray-project/ray into win_… 

    …path_fix
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5e63aa0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' of https://github.com/ray-project/ray into win_… 

    …path_fix
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a07521a View commit details
    Browse the repository at this point in the history

  12. fix lint 

    Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    de7dc72 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'master' of https://github.com/ray-project/ray into win_… 

    …path_fix

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
    @justinvyu
    justinvyu committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    14fbb18 View commit details
    Browse the repository at this point in the history