[Core] Make sure redis sync context and async context connect to the same redis instance #42040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are using ip for redis sync context connection but domain name for redis async context so there is a chance redis async context doesn't connect to the master.
I think what can happen is that during
RedisContext::Connect()
, the domain name is resolved to two ips (ip[0] is master, ip[1] is replica). sync context is connected to ip[0] so it's fine while async context is connected using domain name so it might be connected to ip[1] which is a replica. Later on we have check to make sure we are connected to the master but we only do the check for sync context so we don't realize that the async context is connected to the replica. Then when we use async context to sendHGET
request, replica will return MOVED (https://redis.io/commands/readonly/) to redirect us to the master and since we don't handle MOVED at that time, it failed.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.