[data][train] Fix locality config not being respected in DataConfig #42204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <chenh1024@gmail.com>
stephanie-wang
approved these changes
Jan 5, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…ay-project#42204) Fix the bug that the locality config in DataConfig is not respected. This bug makes locality always enabled for training ingest workloads. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
added a commit
to raulchen/ray
that referenced
this pull request
Jan 26, 2024
…ay-project#42204) Fix the bug that the locality config in DataConfig is not respected. This bug makes locality always enabled for training ingest workloads. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
8 tasks
architkulkarni
added a commit
that referenced
this pull request
Jan 29, 2024
…42204) (#42722) Cherry-pick #42204 to 2.9.2. This PR fixes a bug on the locality config that will cause bad perf for training with heterogenous clusters. Fix the bug that the locality config in DataConfig is not respected. This bug makes locality always enabled for training ingest workloads. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix the bug that the locality config in DataConfig is not respected. This bug makes locality always enabled for training ingest workloads.
Related issue number
#40607
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.