Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train] Split overloaded
ray.train.torch.get_device
into anotherget_devices
API for multi-GPU worker setup #42314[Train] Split overloaded
ray.train.torch.get_device
into anotherget_devices
API for multi-GPU worker setup #42314Changes from 20 commits
dfad3e6
ed93ecf
7fb61ea
25f839a
56ddd9f
2362a74
c475d6f
d1f8f90
9c85e0a
64a25f1
9c08275
de63ce7
86316f6
2c8150b
6600da2
8cd147b
8f6845d
dd67076
c24b740
10a42a9
8832876
0d83f42
193d527
9ff4cd3
8e171fa
1b8639b
aaa0793
9a52ae9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this wasn't actually working as expected before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a new
TRAIN_TORCH_GET_DEVICES
key.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah previously Justin mentioned we can use a single Key for these two APIs. But now I think it makes more sense to have a separate one to get more accurate telemetry data.