[ray dashboard] Actor page polish #42588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 22, 2024 16:00
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
nikitavemuri
force-pushed
the
nikita/actor_node_id_table
branch
from
684be61
to
c033cc1
Compare
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
alanwguo
approved these changes
Jan 24, 2024
| @@ -267,6 +270,19 @@ const ActorTable = ({ | |||
| <TextField {...params} label="IP" /> | |||
| )} | |||
| /> | |||
| <Autocomplete | |||
| data-testid={"nodeIdFilter"} | |||
There was a problem hiding this comment.
nit: for strings, lets's avoid unnecessary brackets.
Suggested change
| data-testid={"nodeIdFilter"} | |
| data-testid="nodeIdFilter" |
| /> | ||
| <TextField | ||
| style={{ margin: 8, width: 120 }} | ||
| label="Repr" |
There was a problem hiding this comment.
nit: I wonder if repr should be lowercased? I don't think Repr is an actual word.
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Jan 24, 2024
Add search by "Class" and "Repr" on actors table page in addition to "Name" Include "Node ID" of actor as column which links to the node ID detail page. Also support filtering by node ID (will later be useful to sort by various columns within a node) --------- Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com> Co-authored-by: Nikita Vemuri <nikitavemuri@anyscale.com> Signed-off-by: Frank Luan <lsf@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.