Fix IS_PYDANTIC_2 logic for pydantic<1.9.0
#42704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pydantic-check
GeneDer
approved these changes
Jan 25, 2024
shrekris-anyscale
approved these changes
Jan 25, 2024
zcin
approved these changes
Jan 25, 2024
edoakes
added a commit
to edoakes/ray
that referenced
this pull request
Jan 25, 2024
The `__version__` attribute didn't exist prior to `1.9.0` and our check does not work properly. Tested manually with `pip install -U pydantic==1.8.0`. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
architkulkarni
pushed a commit
that referenced
this pull request
Jan 29, 2024
The __version__ attribute didn't exist prior to 1.9.0 and our check does not work properly. Tested manually with pip install -U pydantic==1.8.0. Related issue number Closes #42413 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
__version__attribute didn't exist prior to1.9.0and our check does not work properly.Tested manually with
pip install -U pydantic==1.8.0.Related issue number
Closes #42413
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.