[Serve] Pin the fastapi & starlette version to avoid breaking proxy

ci/docker/min.build.wanda.yaml

@@ -11,4 +11,4 @@ build_args:
   - PYTHON_VERSION
   - EXTRA_DEPENDENCY
 tags:
-  - cr.ray.io/rayproject/minbuild-$EXTRA_DEPENDENCY-py$PYTHON_VERSION
+  - cr.ray.io/rayproject/minbuild-$EXTRA_DEPENDENCY-py$PYTHON_VERSION

python/ray/serve/_private/proxy.py

@@ -10,8 +10,10 @@
 from typing import Any, Callable, Dict, Generator, List, Optional, Tuple, Type
 
 import grpc
+import starlette
 import starlette.routing
 import uvicorn
+from packaging import version
 from starlette.datastructures import MutableHeaders
 from starlette.middleware import Middleware
 from starlette.types import Receive
@@ -1211,9 +1213,18 @@ def __init__(
         self.wrapped_http_proxy = self.http_proxy
 
         for middleware in http_middlewares:
-            self.wrapped_http_proxy = middleware.cls(
-                self.wrapped_http_proxy, **middleware.options
-            )
+            if version.parse(starlette.__version__) < version.parse("0.35.0"):
+                self.wrapped_http_proxy = middleware.cls(
+                    self.wrapped_http_proxy, **middleware.options
+                )
+            else:
+                # In starlette >= 0.35.0, middleware.options does not exist:
+                # https://github.com/encode/starlette/pull/2381.
+                self.wrapped_http_proxy = middleware.cls(
+                    self.wrapped_http_proxy,
+                    *middleware.args,
+                    **middleware.kwargs,
+                )
 
         # Start running the HTTP server on the event loop.
         # This task should be running forever. We track it in case of failure.

python/requirements.txt

@@ -40,7 +40,7 @@ pyyaml
 rich
 gpustat>=1.0.0
 opentelemetry-sdk
-fastapi
+fastapi<=0.108.0
 gymnasium==0.28.1
 virtualenv!=20.21.1,>=20.0.24
 opentelemetry-api

python/requirements/test-requirements.txt

@@ -17,7 +17,7 @@ cloudpickle==2.2.0
 # Keep in sync with `ci/build/upload_build_info.sh`
 cryptography==38.0.1
 cython==0.29.32
-fastapi==0.104.0
+fastapi==0.108.0
 feather-format==0.4.1
 # Keep compatible with Werkzeug
 flask==2.1.3
@@ -93,7 +93,7 @@ importlib-metadata==4.10.0
 # Some packages have downstream dependencies that we have to specify here to resolve conflicts.
 # Feel free to add (or remove!) packages here liberally.
 tensorboardX==2.6.0
-starlette==0.27.0
+starlette==0.29.0
 h11==0.12.0
 markdown-it-py==1.1.0
 attrs==21.4.0

python/requirements_compiled.txt

@@ -471,7 +471,7 @@ fairscale==0.4.6
     # via -r /ray/ci/../python/requirements/ml/tune-test-requirements.txt
 farama-notifications==0.0.4
     # via gymnasium
-fastapi==0.104.0
+fastapi==0.108.0
     # via
     #   -r /ray/ci/../python/requirements.txt
     #   -r /ray/ci/../python/requirements/test-requirements.txt
@@ -2175,7 +2175,7 @@ sshpubkeys==3.3.1
     # via moto
 stack-data==0.6.3
     # via ipython
-starlette==0.27.0
+starlette==0.29.0
     # via
     #   -r /ray/ci/../python/requirements.txt
     #   -r /ray/ci/../python/requirements/test-requirements.txt

python/setup.py

@@ -267,7 +267,8 @@ def get_packages(self):
             "uvicorn[standard]",
             "requests",
             "starlette",
-            "fastapi",
+            # Tracking issue: https://github.com/tiangolo/fastapi/discussions/10948
+            "fastapi <= 0.108.0",
             "aiorwlock",
             "watchfiles",
         ],