Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9.2][Data] Skip recording memory spilled stats when get_memory_info_reply is failed #42834

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[2.9.2][Data] Skip recording memory spilled stats when get_memory_info_reply is failed #42834

merged 1 commit into from
Jan 30, 2024

Conversation

c21
Copy link
Contributor

@c21 c21 commented Jan 30, 2024 •
edited
Loading

User found the issue the call of get_memory_info_reply throws GRPC error if memory load on cluster is heavy.

Why are these changes needed?

Cherry pick of #42824 to 2.9.2 release branch.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@c21
[Data] Skip recording memory spilled stats when get_memory_info_reply…
776c44b 
… is failed (ray-project#42824)

User found the issue the call of `get_memory_info_reply` throws GRPC error if memory load on cluster is heavy.

Signed-off-by: Cheng Su <scnju13@gmail.com>
@c21 c21 changed the title [2.9.2][Data] Skip recording memory spilled stats when get_memory_info_reply… [2.9.2][Data] Skip recording memory spilled stats when get_memory_info_reply is failed Jan 30, 2024
@c21 c21 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 30, 2024
@c21
Copy link
Contributor Author

c21 commented Jan 30, 2024

PR is good to merge.

@architkulkarni architkulkarni merged commit 0784b9d into ray-project:releases/2.9.2 Jan 30, 2024
14 of 16 checks passed
@c21 c21 deleted the pick-core-memory branch January 30, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@Zandew Zandew Awaiting requested review from Zandew Zandew is a code owner

Assignees

@stephanie-wang stephanie-wang

@raulchen raulchen

@architkulkarni architkulkarni

@zhe-thoughts zhe-thoughts

@bveeramani bveeramani

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability. v2.9.2-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@c21 @zhe-thoughts @bveeramani @stephanie-wang @raulchen @architkulkarni