Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Use application-level retries for Parquet metadata tasks #42922

Merged
merged 10 commits into from Feb 13, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Feb 1, 2024

Why are these changes needed?

#42044 updated the ParquetDatasource logic so that Ray retries metadata fetching tasks that raise OSErrors.

if RETRY_EXCEPTIONS_FOR_META_FETCH_TASK is not None:
prefetch_remote_args[
"retry_exceptions"
] = RETRY_EXCEPTIONS_FOR_META_FETCH_TASK

The problem is that we retry tasks indefinitely, so if a metadata fetching tasks raises a non-transient OSError, your program freezes without warning.

"max_retries": -1,

To fix this issue, this PR replaces the Ray Core-level retry with finite application-level retries. It also updates the retry logic to apply jitter to backoffs that exceed the limit.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani changed the title [Data] Fix Parquet retry [Data] Use application-level retries for Parquet metadata tasks Feb 6, 2024
@bveeramani bveeramani marked this pull request as ready for review February 6, 2024 21:11
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bveeramani! Having some comments.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the test for the user workload.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message LGTM

@bveeramani bveeramani merged commit 9031d9a into ray-project:master Feb 13, 2024
9 checks passed
@bveeramani bveeramani deleted the fix-parquet-retry branch February 13, 2024 01:40
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 17, 2024
…project#42922)

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants