New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Hard deprecate Datasource
-related methods
#42936
Merged
bveeramani
merged 9 commits into
ray-project:master
from
bveeramani:remove-datasource-write
Feb 22, 2024
Merged
[Data] Hard deprecate Datasource
-related methods
#42936
bveeramani
merged 9 commits into
ray-project:master
from
bveeramani:remove-datasource-write
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
Zandew
as code owners
February 2, 2024 01:00
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
commented
Feb 13, 2024
Comment on lines
-34
to
-39
warnings.warn( | ||
"`create_reader` has been deprecated in Ray 2.9. Instead of creating a " | ||
"`Reader`, implement `Datasource.get_read_tasks` and " | ||
"`Datasource.estimate_inmemory_data_size`.", | ||
DeprecationWarning, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this warning to read_datasource
.
bveeramani
changed the title
[Data] Deprecate
[Data] Hard deprecate Feb 14, 2024
Datasource
-related methodsDatasource
-related methods
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We deprecated
write_datasource
and write-relatedDatasource
methods in Ray 2.9. This PR hard deprecates them for Ray 2.10.In specific, this PR hard deprecates
Dataset.write_datasource
and removes the following user-facing APIs:Datasource.on_write_start
Datasource.write
Datasource.on_write_completed
Datasource.on_write_failed
DummyOutputDatasource
(renamed toDummyOutputDatasink
)If a user implements one of the removed methods, their program won't break. Instead, they'll receive a deprecation error when they call
Dataset.write_datasource
.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.