Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Hard deprecate Datasource-related methods #42936

Merged
merged 9 commits into from Feb 22, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Feb 2, 2024

Why are these changes needed?

We deprecated write_datasource and write-related Datasource methods in Ray 2.9. This PR hard deprecates them for Ray 2.10.

In specific, this PR hard deprecates Dataset.write_datasource and removes the following user-facing APIs:

  • Datasource.on_write_start
  • Datasource.write
  • Datasource.on_write_completed
  • Datasource.on_write_failed
  • DummyOutputDatasource (renamed to DummyOutputDatasink)

If a user implements one of the removed methods, their program won't break. Instead, they'll receive a deprecation error when they call Dataset.write_datasource.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Comment on lines -34 to -39
warnings.warn(
"`create_reader` has been deprecated in Ray 2.9. Instead of creating a "
"`Reader`, implement `Datasource.get_read_tasks` and "
"`Datasource.estimate_inmemory_data_size`.",
DeprecationWarning,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this warning to read_datasource.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani changed the title [Data] Deprecate Datasource-related methods [Data] Hard deprecate Datasource-related methods Feb 14, 2024
@bveeramani bveeramani marked this pull request as ready for review February 14, 2024 23:24
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bveeramani bveeramani merged commit d70b5f8 into ray-project:master Feb 22, 2024
9 checks passed
@bveeramani bveeramani deleted the remove-datasource-write branch February 22, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants