Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Hard deprecate BatchMapper #43022

Merged
merged 4 commits into from
Feb 7, 2024
Merged

[Data] Hard deprecate BatchMapper #43022

merged 4 commits into from
Feb 7, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

BatchMapper has been soft deprecated since Ray 2.7. This PR hard deprecates it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
8f7f8ec 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Appease lint
761802b 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Appease lint
a935c86 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
omatthew98
omatthew98 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bveeramani
Fix test
04bf4f4 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
c21 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if any documentation needs to be updated. Thanks.

@bveeramani bveeramani merged commit 164636c into ray-project:master Feb 7, 2024
9 checks passed
ratnopamc pushed a commit to ratnopamc/ray that referenced this pull request Feb 11, 2024
@bveeramani @ratnopamc
[Data] Hard deprecate BatchMapper (ray-project#43022)
d480204 
BatchMapper has been soft deprecated since Ray 2.7. This PR hard deprecates it.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Ratnopam Chakrabarti <ratnopamc@yahoo.com>
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
@bveeramani @tterrysun
[Data] Hard deprecate BatchMapper (ray-project#43022)
589b370 
BatchMapper has been soft deprecated since Ray 2.7. This PR hard deprecates it.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: tterrysun <terry@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@omatthew98 omatthew98 omatthew98 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@Zandew Zandew Awaiting requested review from Zandew

Assignees

@c21 c21

@omatthew98 omatthew98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bveeramani @c21 @omatthew98