[Core] Fix cgroup used memory calculation for Ray memory monitor #43071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
commented
Feb 9, 2024
| return kNull; | ||
| } | ||
| return current_usage_bytes - inactive_file_bytes; | ||
| return current_usage_bytes - inactive_file_bytes - active_file_bytes; |
WeichenXu123
approved these changes
Feb 9, 2024
WeichenXu123
reviewed
Feb 9, 2024
WeichenXu123
suggested changes
Feb 9, 2024
WeichenXu123
approved these changes
Feb 9, 2024
WeichenXu123
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Please refine comments before merging.
https://github.com/ray-project/ray/pull/43071/files#r1483902223
rkooo567
approved these changes
Feb 10, 2024
rkooo567
reviewed
Feb 10, 2024
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 17, 2024
…-project#43071) From oom killer's perspective, file page caches are reclaimable and can be used when kernel needs memory (the memory can be reclaimed by writing the data back to the original file) so we should exclude those when calculating cgroup used memory. Before this PR, we only exclude part of the file page caches that's inactive. This PR excludes both active and inactive Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
From oom killer's perspective, file page caches are reclaimable and can be used when kernel needs memory (the memory can be reclaimed by writing the data back to the original file) so we should exclude those when calculating cgroup used memory.
Before this PR, we only exclude part of the file page caches that's inactive. This PR excludes both active and inactive.
Related issue number
Closes #42894
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.