Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time backpressure #43110
Time backpressure #43110
Changes from 8 commits
9b69978
02aaf21
d29e00d
925c173
0fd0bb2
8ce7724
dc5dee4
296639d
2cc33a3
d3cacbe
ad3b6d0
d1cc9d5
8a836c7
42d65f4
4a861f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when
under_resource_limits or any(...)
, the operator is in backpressure for "task submission".For this one, we can probably rename the metric to something like
in_task_submission_backpressure
.another place regarding backpressure is here. This is to backpressure the output speed of the running tasks.
for the latter, it doesn't seem to make sense to record the "backpressure time". we can think of a better metric later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the metric names to make it more clear this was dealing with task submission backpressure and included the
under_resource_limits
in thein_backpressure
boolean.Did you mean
not under_resource_limits or any(...)
? In other words is this the correct logic:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And agree that makes sense to add something for the second backpressure case but will do that in a later PR when we have a better understanding on what metric would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe move this outside of
TestConcurrencyCapBackpressurePolicy
? since the purpose of this test is to test measuring backpress time, not theConcurrencyCapBackpressurePolicy
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to leave as is to prevent having to duplicate some of the class methods outside the class. Once the metric is being exported, I will remove this duplicated test and include the assert from this test in each of the backpressure policy tests.