[Serve] Config Serve's gRPC proxy to allow large payload #43114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <e870252314@gmail.com>
edoakes
reviewed
Feb 12, 2024
| @@ -61,7 +63,7 @@ def create_serve_grpc_server(service_handler_factory): | |||
| thread_pool=None, | |||
| generic_handlers=(), | |||
| interceptors=(), | |||
| options=(), | |||
| options=GRPC_OPTIONS, | |||
There was a problem hiding this comment.
what are the options supported here? are we sure we want to share the configuration?
There was a problem hiding this comment.
There was a whole list of options that Ray currently supported
ray/python/ray/util/client/common.py
Line 68 in ca88ce7
Signed-off-by: Gene Su <e870252314@gmail.com>
GeneDer
changed the title
edoakes
approved these changes
Feb 12, 2024
|
In the future such things can probably get lumped into some field in the proxy |
tterrysun
pushed a commit
to tterrysun/ray
that referenced
this pull request
Feb 14, 2024
…#43114) --------- Signed-off-by: Gene Su <e870252314@gmail.com> Signed-off-by: tterrysun <terry@anyscale.com>
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 17, 2024
…#43114) --------- Signed-off-by: Gene Su <e870252314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A user reported a bug unable to send large payloads with Serve's gRPC proxy. This PR configs Serve's gRPC proxy ] to allow the clients to setup larger message limits. Also, add a test to ensure this case will be caught in the future.
Related issue number
Closes #43109
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.