[core] Fix protobuf breaking change by adding a compat layer. #43172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
requested review from
ericl,
architkulkarni,
hongchaodeng and
a team
as code owners
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
jjyao
approved these changes
Feb 14, 2024
Comment on lines
36
to
38
| raise ValueError( | ||
| f"Cannot find {old_arg_name} or {new_arg_name} in MessageToDict signature" | ||
| ) |
There was a problem hiding this comment.
I think it's safer to just return kwargs in this case. Since in the future, they might change the signature of MessageToDict to MessageToDict(**kwargs)
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
added a commit
to rynewang/ray
that referenced
this pull request
Feb 15, 2024
…oject#43172) Latest postmerge failure linux://python/ray/tests:test_output turns out to be from a recent protobuf pre-release change. It changed an argument name which breaks our event logger. This PR introduces a compatibility layer to support both args. Also re-enabled core minimal tests in premerge. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
added a commit
that referenced
this pull request
Feb 15, 2024
#43188) Latest postmerge failure linux://python/ray/tests:test_output turns out to be from a recent protobuf pre-release change. It changed an argument name which breaks our event logger. This PR introduces a compatibility layer to support both args. Also re-enabled core minimal tests in premerge. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 17, 2024
…oject#43172) Latest postmerge failure linux://python/ray/tests:test_output turns out to be from a recent protobuf pre-release change. It changed an argument name which breaks our event logger. This PR introduces a compatibility layer to support both args. Also re-enabled core minimal tests in premerge. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest postmerge failure
linux://python/ray/tests:test_outputturns out to be from a recent protobuf pre-release change. It changed an argument name which breaks our event logger. This PR introduces a compatibility layer to support both args.Also re-enabled core minimal tests in premerge.