Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove deprecated Metric methods #43202

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

jjyao
Copy link
Contributor

@jjyao jjyao commented Feb 15, 2024

Why are these changes needed?

Those methods have been deprecated for 3 years and they are DeveloperAPI so it's safe to remove them.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao merged commit ef6c63e into ray-project:master Feb 15, 2024
9 checks passed
@jjyao jjyao deleted the jjyao/red branch February 15, 2024 21:48
omatthew98 pushed a commit to omatthew98/ray that referenced this pull request Feb 17, 2024
Those methods have been deprecated for 3 years and they are DeveloperAPI so it's safe to remove them.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 17, 2024
Those methods have been deprecated for 3 years and they are DeveloperAPI so it's safe to remove them.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants