Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Time streaming exec scheduling" #43283

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Revert "Time streaming exec scheduling" #43283

merged 1 commit into from
Feb 20, 2024

Conversation

can-anyscale
Copy link
Collaborator

Reverts #43112

@can-anyscale
Copy link
Collaborator Author

Test: https://buildkite.com/ray-project/postmerge/builds/3009

@can-anyscale can-anyscale mentioned this pull request Feb 20, 2024
Closed
@can-anyscale
Copy link
Collaborator Author

Test passed on revert: https://buildkite.com/ray-project/postmerge/builds/3009#018dc76e-66da-4bcd-8f72-897d2d8a7646/186-820

@can-anyscale can-anyscale marked this pull request as ready for review February 20, 2024 17:46
@can-anyscale can-anyscale requested review from a team February 20, 2024 17:57
c21
c21 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @raulchen and @scottjlee

@can-anyscale can-anyscale merged commit 2b92f57 into master Feb 20, 2024
9 checks passed
@can-anyscale can-anyscale deleted the revert-43112-time-streaming-exec-sched branch February 20, 2024 18:05
khluu pushed a commit that referenced this pull request Feb 21, 2024
@can-anyscale @khluu
Revert "[Data] Time streaming exec scheduling (#43112)" (#43283)
97bb3f7 
This reverts commit 9641c72.
omatthew98 added a commit that referenced this pull request Feb 26, 2024
@omatthew98
Revert "Revert "[Data] Time streaming exec scheduling (#43112)" (#43283…
30dfbf3 
…)"

This reverts commit 2b92f57.
This was referenced Feb 26, 2024
Closed
Merged
omatthew98 added a commit to omatthew98/ray that referenced this pull request Feb 26, 2024
@omatthew98
Revert "Revert "[Data] Time streaming exec scheduling (ray-project#43112
5a2881e 
)" (ray-project#43283)"

This reverts commit 2b92f57.
omatthew98 added a commit to omatthew98/ray that referenced this pull request Feb 26, 2024
@omatthew98
Revert "Revert "[Data] Time streaming exec scheduling (ray-project#43112
11b5862 
)" (ray-project#43283)"

This reverts commit 2b92f57.

Signed-off-by: Matthew Owen <mowen@anyscale.com>
c21 pushed a commit that referenced this pull request Feb 26, 2024
@omatthew98
Revert "Revert "[Data] Time streaming exec scheduling (#43112)" (#43283…
bca48a3 
…)" (#43433)

This adds an extra `None` check to fix test failures if `self._initial_stats` is not set. This reverts #43283 and restores the changes made in #43112 .

Signed-off-by: Matthew Owen <mowen@anyscale.com>
@omatthew98 omatthew98 mentioned this pull request Mar 4, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@can-anyscale @c21