Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 42152: __common__ in multi-agent env infos dict breaks env pre-checker. #43317

Merged
merged 4 commits into from Mar 1, 2024
Merged

[RLlib] Issue 42152: __common__ in multi-agent env infos dict breaks env pre-checker. #43317

merged 4 commits into from Mar 1, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Feb 21, 2024 •
edited

Issue 42152: __common__ in multi-agent env infos dict breaks env pre-checker.

Why are these changes needed?

Closes #42152

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
fix
d47b2bb 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 mentioned this pull request Feb 21, 2024
Closed
simonsays1980
simonsays1980 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tiny typo.

rllib/utils/pre_checks/env.py Outdated
agent_id in agent_ids
or agent_id == "__all__"
or agent_id == "__common__"
):
error = (
f"Your dones dictionary must have agent ids that belong to "
f"the environment. Agent_ids recieved from "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recieved -> received.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sven1977
typo
5972a9d 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge remote-tracking branch 'origin/issue_42152_common_key_multi_age…
6d71374 
…nt_infos_breaks_env_checker' into issue_42152_common_key_multi_agent_infos_breaks_env_checker
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 22, 2024
@anyscalesam anyscalesam added the rllib RLlib related issues label Feb 28, 2024
@sven1977 sven1977 merged commit 94c5046 into ray-project:master Mar 1, 2024
9 checks passed
hebiao064 pushed a commit to hebiao064/ray that referenced this pull request Mar 12, 2024
@sven1977 @hebiao064
[RLlib] Issue 42152: __common__ in multi-agent env infos dict break…
51e24aa 
…s env pre-checker. (ray-project#43317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@avnishn avnishn Awaiting requested review from avnishn avnishn is a code owner

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha kouroshHakha is a code owner

Assignees
No one assigned
Labels
rllib RLlib related issues tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLLlib] MultiAgentEnv: __common__key in returned info
4 participants
@sven1977 @simonsays1980 @kouroshHakha @anyscalesam