Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Hard deprecate BlockWritePathProvider #43342

Merged

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

We soft deprecated BlockWritePathProvider in favor of FilenameProvider in Ray 2.9 because FilenameProvider is simpler to use and allows you to configure filenames for row-based writes (e.g., images). This PR hard deprecates BlockWritePathProvider for Ray 2.10 and removes dead code.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 0c09fd8 into ray-project:master Feb 22, 2024
9 checks passed
@bveeramani bveeramani deleted the hard-deprecate-block-provider branch February 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants