Docs and test code for PrioritizedEpisodeReplayBuffer.
#43458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
simonsays1980
changed the title
simonsays1980
changed the title
PrioritizedEpisodeReplayBuffer.
sven1977
reviewed
Feb 27, 2024
rllib/utils/replay_buffers/prioritized_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Feb 27, 2024
sven1977
reviewed
Feb 27, 2024
rllib/utils/replay_buffers/prioritized_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Feb 27, 2024
| capacity: The total number of timesteps to be storable in this buffer. | ||
| Will start ejecting old episodes once this limit is reached. | ||
| batch_size_B: The number of rows in a SampleBatch returned from `sample()`. | ||
| batch_length_T: The length of each row in a SampleBatch returned from |
There was a problem hiding this comment.
Can we specify here, how this arg is related to n-step? My understanding is: Not at all, correct?
So, batch_length_T is the same as in DreamerV3, meaning if >1, then my returned batch will contain B rows, each row consisting of T consecutive-in-an-episode(!) n-step tuples, correct?
If so, can we give these details here in the description of the arg?
There was a problem hiding this comment.
Ar rhis moment batch_öength_T=1 is the only possible option. As this is a method inherited from EpisodeReplayBuffer this argument has to be there.
sven1977
reviewed
Feb 27, 2024
| @@ -259,8 +371,8 @@ def sample( | |||
| next_observations = [[] for _ in range(batch_size_B)] | |||
| actions = [[] for _ in range(batch_size_B)] | |||
| rewards = [[] for _ in range(batch_size_B)] | |||
| is_terminated = [[False] * batch_length_T for _ in range(batch_size_B)] | |||
| is_truncated = [[False] * batch_length_T for _ in range(batch_size_B)] | |||
| is_terminated = [[False] for _ in range(batch_size_B)] | |||
There was a problem hiding this comment.
Can you explain, why this fix? B/c a returned batch only has one terminated/truncated flag per batch row?
There was a problem hiding this comment.
Mainly because each batch row has only a single tuple. See my comment above.
sven1977
approved these changes
Feb 27, 2024
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla and
kouroshHakha
as code owners
sven1977
added
the
tests-ok
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
…om:simonsays1980/ray into docs-for-prioritized-episode-replay-buffer Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We move from plain timesteps to episodes in the buffer. This needs some rigorous documentation with appropriate test code to show users how to use a class.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.