Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] update serve logging config docs #43483

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Feb 28, 2024

Why are these changes needed?

Re: https://anyscaleteam.slack.com/archives/C02UGNK9080/p1708651153916139

  • Updated code examples to be complete with imports and requests so it works out of box
  • Added info on RAY_SERVE_ENABLE_JSON_LOGGING getting deprecated in the future release and using RAY_SERVE_LOG_ENCODING if need a global config
  • Run through all examples and update the existing logs

Related issue number

Closes: #43375
Closes: https://github.com/anyscale/product/issues/25836

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
GeneDer and others added 3 commits February 28, 2024 08:40
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Gene Der Su <gdsu@ucdavis.edu>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer
Copy link
Contributor Author

GeneDer commented Feb 29, 2024

@edoakes this is ready for merge

@edoakes edoakes merged commit 7af6abc into ray-project:master Feb 29, 2024
9 checks passed
@GeneDer GeneDer deleted the update-logging-config-doc branch February 29, 2024 17:01
hebiao064 pushed a commit to hebiao064/ray that referenced this pull request Mar 12, 2024
- Updated code examples to be complete with imports and requests so it works out of box
- Added info on RAY_SERVE_ENABLE_JSON_LOGGING getting deprecated in the future release and using RAY_SERVE_LOG_ENCODING if need a global config
- Run through all examples and update the existing logs

---------

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Der Su <gdsu@ucdavis.edu>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
- Updated code examples to be complete with imports and requests so it works out of box
- Added info on RAY_SERVE_ENABLE_JSON_LOGGING getting deprecated in the future release and using RAY_SERVE_LOG_ENCODING if need a global config
- Run through all examples and update the existing logs

---------

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Der Su <gdsu@ucdavis.edu>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serve] Ensure Serve logging docs are up-to-date
2 participants