-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] update serve logging config docs #43483
Merged
edoakes
merged 6 commits into
ray-project:master
from
GeneDer:update-logging-config-doc
Feb 29, 2024
Merged
[Serve] update serve logging config docs #43483
edoakes
merged 6 commits into
ray-project:master
from
GeneDer:update-logging-config-doc
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
edoakes
reviewed
Feb 28, 2024
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Gene Der Su <gdsu@ucdavis.edu>
edoakes
approved these changes
Feb 28, 2024
@edoakes this is ready for merge |
hebiao064
pushed a commit
to hebiao064/ray
that referenced
this pull request
Mar 12, 2024
- Updated code examples to be complete with imports and requests so it works out of box - Added info on RAY_SERVE_ENABLE_JSON_LOGGING getting deprecated in the future release and using RAY_SERVE_LOG_ENCODING if need a global config - Run through all examples and update the existing logs --------- Signed-off-by: Gene Su <e870252314@gmail.com> Signed-off-by: Gene Der Su <gdsu@ucdavis.edu> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
- Updated code examples to be complete with imports and requests so it works out of box - Added info on RAY_SERVE_ENABLE_JSON_LOGGING getting deprecated in the future release and using RAY_SERVE_LOG_ENCODING if need a global config - Run through all examples and update the existing logs --------- Signed-off-by: Gene Su <e870252314@gmail.com> Signed-off-by: Gene Der Su <gdsu@ucdavis.edu> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Re: https://anyscaleteam.slack.com/archives/C02UGNK9080/p1708651153916139
RAY_SERVE_ENABLE_JSON_LOGGING
getting deprecated in the future release and usingRAY_SERVE_LOG_ENCODING
if need a global configRelated issue number
Closes: #43375
Closes: https://github.com/anyscale/product/issues/25836
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.